Review Request: Avoid two possible NULL pointer access.

Thorsten Zachmann t.zachmann at zagge.de
Fri Jun 17 09:19:56 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101644/#review3950
-----------------------------------------------------------

Ship it!


Looks good. If you have commit access please commit or otherwise let me know and I can commit it for you.

- Thorsten


On June 16, 2011, 5:59 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101644/
> -----------------------------------------------------------
> 
> (Updated June 16, 2011, 5:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> The paCanvas and canvasItem are referenced without checking if they are not NULL.
> If they can not be null, then I'll change the patch to remove the not NULL checking.
> 
> 
> Diffs
> -----
> 
>   active/src/CanvasController.cpp ee7b90a 
> 
> Diff: http://git.reviewboard.kde.org/r/101644/diff
> 
> 
> Testing
> -------
> 
> I have not seen anything strange after the patch.
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/calligra-devel/attachments/20110617/3a065496/attachment-0001.htm 


More information about the calligra-devel mailing list