Review Request: Block close event while loading file

[C. Boemann]

On Tuesday 14 June 2011 17:50:54 Sven Langkamp wrote:
> > On June 14, 2011, 7:50 a.m., Boudewijn Rempt wrote:
> > > well... yes... it's kind of a stop-gap, because we should actually be
> > > able to cancel the loading and close the window.
> 
> In practice the UI is blocked until loading is finished. Loading currently
> isn't designed to be cancelable. So I think that it's currently better to
> block it than to crash. It can be easily reverted once cancel is possible.
> 
> Ideally loading would too fast to be canceled ;)
> 
> 
> - Sven
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101611/#review3874
> -----------------------------------------------------------
> 
> On June 14, 2011, 2:45 a.m., Sven Langkamp wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/101611/
> > -----------------------------------------------------------
> > 
> > (Updated June 14, 2011, 2:45 a.m.)
> > 
> > 
> > Review request for Calligra.
> > 
> > 
> > Summary
> > -------
> > 
> > Currently closing the window while loading a file can crash the
> > application. The patch fixes the problem by ignoring close events while
> > loading.
> > 
> > 
> > This addresses bug 273081.
> > 
> >     http://bugs.kde.org/show_bug.cgi?id=273081
> > 
> > Diffs
> > -----
> > 
> >   libs/main/KoDocument.cpp 29507fc
> >   libs/main/KoMainWindow.cpp a45ce97
> > 
> > Diff: http://git.reviewboard.kde.org/r/101611/diff
> > 
> > 
> > Testing
> > -------
> > 
> > Tested and works in Krita.
> > 
> > 
> > Thanks,
> > 
> > Sven
that is not true for all applications so I'd oppose this change and ask for a 
real solution to be found