Review Request: Fixes 274118 and couple of other fixes

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101500/#review3855
-----------------------------------------------------------


The attach patch breaks displaying of lists. 

I have uploaded some test files to: http://www.zagge.de/anchor/gopalK/ with images of how it looked before (without your patch) and after(with your patch).

As far as I understood the spec the 
text-indent is used to position the list item in position of the list fo:margin-left. If listtab is used and no tab-stops are defined the list starts at fo:margin-left.

I found the following posting http://lists.oasis-open.org/archives/office/200703/msg00031.html which describes parts of the design. Also I will try to get more information in the next ODF TC calls about that as the specification is not very clear in describing this.

- Thorsten


On June 11, 2011, 8:17 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101500/
> -----------------------------------------------------------
> 
> (Updated June 11, 2011, 8:17 p.m.)
> 
> 
> Review request for Calligra, Thorsten Zachmann and Casper Boemann.
> 
> 
> Summary
> -------
> 
> This fixes bugs 274118 and 244345. This also fixes the broken list label alignment feature. 
> 
> 
> This addresses bugs 244345 and 274118.
>     http://bugs.kde.org/show_bug.cgi?id=244345
>     http://bugs.kde.org/show_bug.cgi?id=274118
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoText.cpp 8b1bdde 
>   libs/kotext/styles/KoListLevelProperties.cpp 6f02874 
>   libs/kotext/styles/KoListStyle.h aeb0e47 
>   libs/textlayout/KoTextLayoutArea.cpp f57958a 
>   libs/textlayout/KoTextLayoutArea_paint.cpp ec70381 
>   libs/textlayout/ListItemsHelper.cpp 90f82a7 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 97ee24a 
>   plugins/textshape/dialogs/ParagraphIndentSpacing.h 3ea8323 
>   plugins/textshape/dialogs/ParagraphIndentSpacing.cpp bb4c224 
> 
> Diff: http://git.reviewboard.kde.org/r/101500/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110613/543ef43c/attachment.htm>