Review Request: Stage: GSoC: Integrate standard edit actions in Slides Sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101562/#review3839
-----------------------------------------------------------

Ship it!


Please fix the things I pointed out and commit. I have not tested the patch, but it looks quite good. Will tests once this hits master.


kpresenter/part/KPrSlidesManagerView.h
<http://git.reviewboard.kde.org/r/101562/#comment3110>

    Please remove this change
    



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/101562/#comment3111>

    Please remove the blank after ( and before )
    
    Please use one (and only one) blank ,



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/101562/#comment3112>

    This be removed as the base class is called automatically. 



libs/flake/KoCopyController.cpp
<http://git.reviewboard.kde.org/r/101562/#comment3113>

    Please use brackets also for one line if statements as defined in the kde code style.


- Thorsten


On June 9, 2011, 11:50 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101562/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 11:50 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Integrate the following standard Actions in Stage Slides Sorter View (connect actions to standard shortcuts and toolbar/menu buttons):
> - Copy, Cut, Paste
> - Select/Deselect all
> - Delete current selection
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrSlidesManagerView.h f13cd34929ace40bf24246cc1d2e9d749ac379d3 
>   kpresenter/part/KPrSlidesManagerView.cpp 1161516b2f0adebded6a6a490973ba5262f37f4a 
>   kpresenter/part/KPrViewModeSlidesSorter.h 7f110c6b59c3733baa9a8b3a76439ba4599d9b3d 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 15156435b8eaab8d1f83077590489bac825e26c0 
>   libs/flake/KoCopyController.cpp 2ecab11e24dcea6c7c66787b4d4f7298ba01ae6f 
>   libs/kopageapp/KoPAView.h f5dd5fbe1461ba23e6ddb86587d1f3e762e1f99b 
>   libs/kopageapp/KoPAView.cpp 088deb103c9384819faab9b9f79c72f66f75e397 
> 
> Diff: http://git.reviewboard.kde.org/r/101562/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110611/7bce19d6/attachment.htm>