reviewrequest

[Boudewijn Rempt]

On Monday 06 June 2011 Jun, Boudewijn Rempt wrote:
> On Monday 06 June 2011 Jun, Burkhard Lück wrote:
> > Am Montag, 6. Juni 2011, um 21:29:11 schrieb Boudewijn Rempt:
> > > On Monday 06 June 2011 Jun, Burkhard Lück wrote:
> > > > Am Montag, 6. Juni 2011, um 12:31:18 schrieb Boudewijn Rempt:
> > > > > With a little help from perl, I replaced all occurrence of KOffice with
> > > > > Calligra in all permutations and all filenames. The diff is a bit too
> > > > > big to post here on the mailing list, so please check
> > > > > 
> > > > > https://git.reviewboard.kde.org/r/101521/
> > > > 
> > > > Converting the entities from general.entities is a *very* bad idea:
> > > > 
> > > > 1) Lot of work for translators
> > > > 2) No single line in the documentation is mor up to date
> > > > 
> > > > If you want to get rid of the koffice name and the koffice apps names,
> > > > please:
> > > > 
> > > > 1) Add to all index.docbooks in calligra docs:
> > > > <!ENTITY koffice "Calligra">
> > > 
> > > Okay, just to be sure: the entity should still be called "koffice"?
> > > 
> > Yes, don't change any entity in a docbook body, instead provide a new 
> > "translation" for each entity in the header like in this case where you change 
> > the "translation" of &koffice; from "KOffice" to "Calligra".
> 
> Okay. Clear. I will split my patch tomorrow, fix the docs like you propose and do a new review request. Thanks for all the input!
> 
> 

I split the patch. The doc part is pending review from Burkhard. Any objection to merging the code part of the patch?

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org