Review-request: Fix infinite loop caused by variable-refresh

Sebastian Sauer mail at dipe.org
Fri Jun 3 22:09:38 CEST 2011


C. Boemann wrote:
> On Friday 03 June 2011 21:13:59 Sebastian Sauer wrote:
>> Hi,
>> 
>> attached patch fixes the infinite loop with the document attached to
>> comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 .
>> 
>> The idea is to not include the previous and next root-areas and mark them
>> dirty if charsAdded and charsRemoved ==0 what means no characters where
>> changed. In such a case we can assume that the change is related to the
>> current root-area only.

> well think of the first line being 48 point font being changed to 8pt.
> wouldnt this affect the previos page??

This emits charsAdded>0 and charsRemoved>0. In that case the previous logic 
still applies. It seems the only case where we have charsAdded==0 and 
charsRemoved==0 is with variables where we call documentChanged ourself.

Attached an updated patch that adds an additional comment for that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: VariableRefresh-02.patch
Type: text/x-patch
Size: 3041 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/calligra-devel/attachments/20110603/bc7bc6d3/attachment.patch 


More information about the calligra-devel mailing list