Review Request: The basic web widget in Kexi reports, put up for review.The widget is not yet painted on report canvas.Please suggest possible issues
Jarosław Staniek
staniek at kde.org
Sat Jul 30 23:43:59 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102046/#review5245
-----------------------------------------------------------
plugins/reporting/web/KoReportDesignerItemweb.h
<http://git.reviewboard.kde.org/r/102046/#comment4739>
web -> Web in KoReportDesignerItemweb and KoReportItemweb
plugins/reporting/web/KoReportItemweb.h
<http://git.reviewboard.kde.org/r/102046/#comment4738>
methods first
plugins/reporting/web/KoReportItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4737>
Always lowercase (!)
Url -> url
plugins/reporting/web/KoReportwebPlugin.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4736>
web Element -> Web element
plugins/reporting/web/koreport_webplugin.desktop
<http://git.reviewboard.kde.org/r/102046/#comment4735>
Plugin -> plugin
- Jarosław
On July 30, 2011, 9:38 a.m., Shreya Pandit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102046/
> -----------------------------------------------------------
>
> (Updated July 30, 2011, 9:38 a.m.)
>
>
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
>
>
> Summary
> -------
>
> Web widget for reports.Please suggest changes
>
>
> This addresses bug no.
> http://bugs.kde.org/show_bug.cgi?id=no
>
>
> Diffs
> -----
>
> plugins/reporting/web/KoReportwebPlugin.h PRE-CREATION
> plugins/reporting/web/KoReportwebPlugin.cpp PRE-CREATION
> plugins/reporting/web/KoReportItemweb.cpp PRE-CREATION
> plugins/reporting/web/KoReportDesignerItemweb.h PRE-CREATION
> plugins/reporting/web/KoReportItemweb.h PRE-CREATION
> plugins/reporting/web/koreport_webplugin.desktop PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/102046/diff
>
>
> Testing
> -------
>
> built
>
>
> Thanks,
>
> Shreya
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110730/058c79aa/attachment.htm>
More information about the calligra-devel
mailing list