Review Request: Make parsing and drawing of the vectorshape threaded (2th try)

Sebastian Sauer mail at dipe.org
Tue Jul 26 18:54:06 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102093/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

Attachd patch makes the probably rather expensive initial parsing and drawing on the QImage operations in the Vectorshape threaded.

The thread will only be used to produce the QImage we are using later on to display the vectorshape. Drawing of the QImage itself is not threaded but then that's not an expensive operation like parsing and producing those QImage can be.

Compared to the previous review-request ( https://git.reviewboard.kde.org/r/102028/diff/ ) we now also handle the case that Qt doesn't support threaded font rendering what could be a problem cause some of the VectorShape-backends are using QPainter::drawText. As alternate I tried to use QPainterPath as suggested at http://www.qtcentre.org/archive/index.php/t-6542.html but the results are rather bad. Looks like text rendered with QPainterPath has "quantisationeffects" (not sure if that's a proper translation to english) even if AntiAliasing is enabled (testapp is at http://paste.kde.org/101725/ ).


Diffs
-----

  plugins/vectorshape/VectorShape.h 4229842 
  plugins/vectorshape/VectorShape.cpp 0a28dac 

Diff: http://git.reviewboard.kde.org/r/102093/diff


Testing
-------


Thanks,

Sebastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/calligra-devel/attachments/20110726/d9841a0e/attachment.htm 


More information about the calligra-devel mailing list