Review Request: The basic web widget in Kexi reports, put up for review.The widget is not yet painted on report canvas.Please suggest possible issues

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102046/#review4989
-----------------------------------------------------------



plugins/reporting/Web/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102046/#comment4375>

    Please change Web/ to web/



plugins/reporting/Web/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102046/#comment4376>

    Please replace Webplugin to webplugin everywhere



plugins/reporting/Web/KoReportDesignerItemWeb.h
<http://git.reviewboard.kde.org/r/102046/#comment4379>

    Replace "Kexi Report Plugin", with typical description in every file:
    
    This file is part of the KDE project
    
    (see e.g. kexi/kexi_version.h)
    Use this style always in every file.
    
    You can add README in your web/ directory and enter "Web element plugin for Calligra Reports" there.
    



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4380>

    fix the header as described above; this file is not OpenRPT...



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4381>

    wrong indentation



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4383>

    Change to just "Web" since we're not browsing anything in case of reports
    



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4384>

    too many ';'



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4385>

    fix indentation



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4386>

    perhaps rather report:web?



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4398>

    indentations (!)



plugins/reporting/Web/KoReportDesignerItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4399>

    if should be 2 line big



plugins/reporting/Web/KoReportItemWeb.h
<http://git.reviewboard.kde.org/r/102046/#comment4397>

    fix header



plugins/reporting/Web/KoReportItemWeb.h
<http://git.reviewboard.kde.org/r/102046/#comment4396>

    remove this commented out code



plugins/reporting/Web/KoReportItemWeb.h
<http://git.reviewboard.kde.org/r/102046/#comment4395>

    move this body to .cpp



plugins/reporting/Web/KoReportItemWeb.h
<http://git.reviewboard.kde.org/r/102046/#comment4400>

    wrong convention, use m_ prefix, not my_



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4394>

    fix header



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4393>

    this big commented code had to be removed?



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4392>

    As I asked before, this should be "report:url"
    



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4391>

    change "item-Web-url", to "url"
    
    change i18n("url") to i18n("Url") - this is visible property name



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4390>

    should be "web" not "Web"
    



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4401>

    indent 



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4402>

    hardcoded, remove soon



plugins/reporting/Web/KoReportItemWeb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4403>

    how this can work if 'id' is declared below?



plugins/reporting/Web/KoReportWebPlugin.h
<http://git.reviewboard.kde.org/r/102046/#comment4389>

    fix the header as described above



plugins/reporting/Web/KoReportWebPlugin.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4388>

    fix the header as described above



plugins/reporting/Web/KoReportWebPlugin.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4405>

    change to report:web



plugins/reporting/Web/KoReportWebPlugin.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4387>

    change to "Web Element"



plugins/reporting/Web/koreport_Webplugin.desktop
<http://git.reviewboard.kde.org/r/102046/#comment4406>

    lowercase -> koreport_webplugin.desktop



plugins/reporting/Web/koreport_Webplugin.desktop
<http://git.reviewboard.kde.org/r/102046/#comment4407>

    lowercase -> koreport_webplugin


- Jarosław


On July 22, 2011, 6:20 p.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102046/
> -----------------------------------------------------------
> 
> (Updated July 22, 2011, 6:20 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Summary
> -------
> 
> Web widget for reports.Please suggest changes
> 
> 
> This addresses bug no.
>     http://bugs.kde.org/show_bug.cgi?id=no
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/Web/CMakeLists.txt PRE-CREATION 
>   plugins/reporting/Web/KoReportDesignerItemWeb.h PRE-CREATION 
>   plugins/reporting/Web/KoReportDesignerItemWeb.cpp PRE-CREATION 
>   plugins/reporting/Web/KoReportItemWeb.h PRE-CREATION 
>   plugins/reporting/Web/KoReportItemWeb.cpp PRE-CREATION 
>   plugins/reporting/Web/KoReportWebPlugin.h PRE-CREATION 
>   plugins/reporting/Web/KoReportWebPlugin.cpp PRE-CREATION 
>   plugins/reporting/Web/koreport_Webplugin.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102046/diff
> 
> 
> Testing
> -------
> 
> built
> 
> 
> Thanks,
> 
> Shreya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110726/72cb21a9/attachment.htm>