Review Request: Fix crash in KoColorPopupAction::updateIcon() when changing colour from outside UI thread

Dan Leinir Turthra Jensen admin at leinir.dk
Mon Jul 25 12:30:26 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102082/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

If one were to call addController without ensuring this happened in the UI thread, or before painter was ready, the previous code would cause a segfault. This diff fixes the problem.


Diffs
-----

  libs/widgets/KoColorPopupAction.cpp d97a04c 

Diff: http://git.reviewboard.kde.org/r/102082/diff


Testing
-------

Constructing tools outside the main thread, no crashes could be provoked in the new code.


Thanks,

Dan Leinir Turthra

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110725/0920a32e/attachment.htm>


More information about the calligra-devel mailing list