Review Request: unused-but-set-variable-warning
Commit Hook
null at kde.org
Thu Jul 21 20:21:22 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101911/#review4945
-----------------------------------------------------------
This review has been submitted with commit 3faddd3c5aed851f32ff5bfa664988d10c0faf55 by Sune Vuorela to branch master.
- Commit
On July 10, 2011, 9:10 p.m., Sune Vuorela wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101911/
> -----------------------------------------------------------
>
> (Updated July 10, 2011, 9:10 p.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> The commented out code looks like it is trying to read a string, 'count', then parsing the content of 'count' as a integer into 'countNumber' and then trowing it all away.
>
> The code at least gives a compiler warning about countNumber set, but never used. I'm not 100% sure that my analysis above is correct.
>
> The right fix is probably to not #if 0 the code out, but to remove it completely, assuming my analysis is correct.
>
>
> Diffs
> -----
>
> filters/tables/xlsx/XlsxXmlStylesReader.cpp 55ccd1ae73b29f4f93140fd906ee218dd4887623
>
> Diff: http://git.reviewboard.kde.org/r/101911/diff
>
>
> Testing
> -------
>
> Code compiles without warnings.
>
>
> Thanks,
>
> Sune
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110721/9f70e54b/attachment.htm>
More information about the calligra-devel
mailing list