Review Request: Fix table-borders are sometimes not visible
Casper Boemann
cbr at boemann.dk
Tue Jul 19 16:56:32 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102007/#review4858
-----------------------------------------------------------
Super and I approve of the approach, but Pierre is restructuring the border class code right now, so we need to get his approval to not mess with his work
- Casper
On July 19, 2011, 3:50 p.m., Sebastian Sauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102007/
> -----------------------------------------------------------
>
> (Updated July 19, 2011, 3:50 p.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> Attached patch fixes the case that sometimes we don't proper display table-borders. The reason for that is that we don't take the width of outer borders into account and therefore on clipping the outlineRect in TextShape.cpp:137 we may end in cuting off those outer-borders.
>
>
> Diffs
> -----
>
> libs/kotext/styles/KoTableBorderStyle.h ccd188b
> libs/kotext/styles/KoTableBorderStyle.cpp 680f320
> libs/textlayout/KoTextLayoutTableArea.cpp dbf5d96
>
> Diff: http://git.reviewboard.kde.org/r/102007/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110719/9c9b7fce/attachment.htm>
More information about the calligra-devel
mailing list