Review Request: remove split view functionality

[Boudewijn Rempt]

> On July 18, 2011, 3:19 p.m., Sven Langkamp wrote:
> > Having two windows side by side introduces lots of other problem:
> > -It would bring back the jumping when switching views, because dockers would be hidden and shown all the time.
> > -You can't have the dockers on one side of the screen as there are two different windows.
> > -You need a good window manager, so that on splitting the windows appear side by side.
> > 
> > Some of the problems with the current system are there because we tried to avoid those problems e.g. we switch the dockers internally to avoid the jumping. The problem you pointed out a purely implementation problems and not problems with the design of the UI. I don't think that we should change the UI just because the implementation isn't working.

Yes, I agree in principle... But the design limits the usefulness because we cannot have two different documents in one window in any case, and given the problems we have had over the years with this feature I doubt that we will manage to have it fixed. And there are so many crashes and every new docker makes it likely we'll get one more crash that I don't think trying to fix this ancient code is worth it.  It's not like other apps all have this feature -- LibreOffice doesn't. But I'd welcome a patch that really fixes split view -- though whether that should be based on the current, very ancient, code, I don't know.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101993/#review4819
-----------------------------------------------------------


On July 18, 2011, 1:03 p.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101993/
> -----------------------------------------------------------
> 
> (Updated July 18, 2011, 1:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch removes the buggy split-view functionality from KoMainWindow. split-view has a number of problems:
> 
> * crashes when removing views
> * duplicates the actions so when a view is split you cannot e.g. delete a shape with the delete key
> * it is limited in that it can only show views on one document, instead of splitting the view and then making it possible to show several documents side-by-side
> 
> After discussion on irc, we felt it was better to let the window manager handle side-by-side views. To that end, a patch to optionally hide dockers if the window loses focus will follow.
> 
> 
> This addresses bugs 239309, 265200, 277953, and 278000.
>     http://bugs.kde.org/show_bug.cgi?id=239309
>     http://bugs.kde.org/show_bug.cgi?id=265200
>     http://bugs.kde.org/show_bug.cgi?id=277953
>     http://bugs.kde.org/show_bug.cgi?id=278000
> 
> 
> Diffs
> -----
> 
>   flow/part/flow.rc bd2913a 
>   karbon/data/karbon.rc 18c7156 
>   kpresenter/part/stage.rc d48fd3c 
>   kpresenter/stage.rc 3e0f53d 
>   krita/krita.rc 3d5d85d 
>   libs/main/KoDocument.cpp 515911a 
>   libs/main/KoMainWindow.h d44aff6 
>   libs/main/KoMainWindow.cpp c629827 
>   tables/tables.rc 0fde1b6 
>   words/part/words.rc 4e10d36 
> 
> Diff: http://git.reviewboard.kde.org/r/101993/diff
> 
> 
> Testing
> -------
> 
> Started several apps, opened and closed documents.
> 
> 
> Thanks,
> 
> Boudewijn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110719/e19e7233/attachment.htm>