Review Request: Make sure to link to the iconv libraries when running the wv2 checks

Raphael Kubo da Costa kubito at gmail.com
Fri Jul 15 03:47:35 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101951/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

When iconv is installed in a path not searched by default by the compiler (such as /usr/local on FreeBSD), the wv2 checks for iconv fail, as the linker does not find libiconv.so to link to it and the compiler cannot find iconv.h.

This patch passes ICONV_LIBRARIES and ICONV_INCLUDE_DIR to the try_run call, making sure the program compiles and links fine.


Diffs
-----

  filters/words/CMakeLists.txt 22c5115 

Diff: http://git.reviewboard.kde.org/r/101951/diff


Testing
-------

The FreeBSD user who was having wv2 detection problems says it worked fine.


Thanks,

Raphael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110715/cc61f6c1/attachment.htm>


More information about the calligra-devel mailing list