Review Request: Take tool actions from the actioncollection instead of disable them

[Sven Langkamp]

> On July 13, 2011, 6:43 p.m., Jan Hambrecht wrote:
> > Wouldn't that mean that only the actions of the currently active tool can be configured? And I did not find anything related to the toolmanager in the backtrace of the bug you mentioned.
> 
> Sven Langkamp wrote:
>     Configuring tool action wouldn't work in that case anyway, even with the old system. There can be several tools with the same action.
>     
>     It doesn't show up in the backtrace, because the toolmanager only sets the action. The crash happens because a deactivated tool gets a signal from an action that shouldn't be active at that moment.

For configuring shortcuts it would be required that every action only exists once which isn't the case.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101937/#review4704
-----------------------------------------------------------


On July 12, 2011, 11:07 p.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101937/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 11:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Currently all tool actions are added at start and then disabled and enabled. Bug 276150 shows a problem with that: The actions that are colliding with the actions of the new active tool are disabled on activation and enabled at deactivation. This causes a bug when the first tools activate tool actions for non active tools.
> 
> The patch solves the problem by adding the action on tool activation and takeing it from the action collection on deactivation.
> 
> 
> This addresses bug 276150.
>     http://bugs.kde.org/show_bug.cgi?id=276150
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoToolManager.cpp 1807fc4 
> 
> Diff: http://git.reviewboard.kde.org/r/101937/diff
> 
> 
> Testing
> -------
> 
> Works with steps from bug 276150
> 
> 
> Thanks,
> 
> Sven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110713/086a7fed/attachment.htm>