Review Request: Stage: GSoC: New GUI for manage custom slide shows

[Thorsten Zachmann]

> On July 2, 2011, 4:30 a.m., Thorsten Zachmann wrote:
> > kpresenter/part/KPrCustomSlideShowsModel.cpp, lines 198-199
> > <http://git.reviewboard.kde.org/r/101820/diff/1/?file=25789#file25789line198>
> >
> >     What is the resaon for this ordering?
> 
> Paul Mendez wrote:
>     Otherwise the slides are paste in the order that you selected the slides, not in the slides sequence order that I think is more logical.
> 
> Thorsten Zachmann wrote:
>     I'm not so sure about this, but lets test first before we change it.
> 
> Paul Mendez wrote:
>     I have obtained some extrange behaviour without the ordering, but as I have implemented some ordering stuff in many places maybe one of them is unnecesary, so I will test it again.

It was not about this specific sorting, more something in general. I first want to see if the ordering is something we should do or maybe better don't do. That is something that should get some testing. Maybe ask on the mailing list what people think about it. 
It would be good  to have the sorting in a function that can be called from all the places where it is used.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101820/#review4302
-----------------------------------------------------------


On July 8, 2011, 8:02 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101820/
> -----------------------------------------------------------
> 
> (Updated July 8, 2011, 8:02 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> (preliminary) new GUI for manage custom slide shows. 
> Note: As some GUI integration is still missing, it's only a review request, it isn't for merge with master branch.
> (part of GSoC project)
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/CMakeLists.txt 613ff8d3de84a19776df1651c0bd3604fc395099 
>   kpresenter/part/KPrCustomSlideShows.h 7d8a91b67e14e32312fd2706dcede6efac6e1aa7 
>   kpresenter/part/KPrCustomSlideShows.cpp 4088a7446d2992d3d56059bec4ad646b4bbfc77f 
>   kpresenter/part/KPrCustomSlideShowsModel.h PRE-CREATION 
>   kpresenter/part/KPrCustomSlideShowsModel.cpp PRE-CREATION 
>   kpresenter/part/KPrSlidesManagerView.h 6f345e049cdf746e00fdfd9e3e7644668ff9e96e 
>   kpresenter/part/KPrSlidesManagerView.cpp 39e80b1b770584f97e6bfcbcebc06bd107bc1a68 
>   kpresenter/part/KPrSlidesSorterDocumentModel.h a5b65a4d87f8af6a51b4e1992c2ac2a3d23aed37 
>   kpresenter/part/KPrSlidesSorterDocumentModel.cpp 4938e3696bed3fb90c017aba5997c40268ce3e99 
>   kpresenter/part/KPrSlidesSorterItemDelegate.h PRE-CREATION 
>   kpresenter/part/KPrSlidesSorterItemDelegate.cpp PRE-CREATION 
>   kpresenter/part/KPrViewModeSlidesSorter.h 240bd9e0c6b4158ff0726f2e72e4c79982a9ea18 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 61866f8a1344e1999224444d71a46a1a21a1864e 
>   kpresenter/part/commands/KPrAddCustomSlideShowCommand.h PRE-CREATION 
>   kpresenter/part/commands/KPrAddCustomSlideShowCommand.cpp PRE-CREATION 
>   kpresenter/part/commands/KPrDelCustomSlideShowCommand.h PRE-CREATION 
>   kpresenter/part/commands/KPrDelCustomSlideShowCommand.cpp PRE-CREATION 
>   kpresenter/part/commands/KPrEditCustomSlideShowsCommand.h PRE-CREATION 
>   kpresenter/part/commands/KPrEditCustomSlideShowsCommand.cpp PRE-CREATION 
>   kpresenter/part/commands/KPrRenameCustomSlideShowCommand.h PRE-CREATION 
>   kpresenter/part/commands/KPrRenameCustomSlideShowCommand.cpp PRE-CREATION 
>   kpresenter/part/tests/CMakeLists.txt f9b56a6ed55ebe610ae30cd21437975c00c317d1 
>   kpresenter/part/tests/PAMock.h PRE-CREATION 
>   kpresenter/part/tests/TestAddCustomSlideShowCommand.h PRE-CREATION 
>   kpresenter/part/tests/TestAddCustomSlideShowCommand.cpp PRE-CREATION 
>   kpresenter/part/tests/TestDelCustomSlideShowCommand.h PRE-CREATION 
>   kpresenter/part/tests/TestDelCustomSlideShowCommand.cpp PRE-CREATION 
>   kpresenter/part/tests/TestEditCustomSlideShowsCommand.h PRE-CREATION 
>   kpresenter/part/tests/TestEditCustomSlideShowsCommand.cpp PRE-CREATION 
>   kpresenter/part/tests/TestRenameCustomSlideShowCommand.h PRE-CREATION 
>   kpresenter/part/tests/TestRenameCustomSlideShowCommand.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101820/diff
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110712/f0f1f01d/attachment.htm>