Review Request: read XML in the rigth way. ie. <a> <b>\n<c> has 5 nodes, not 3

Jaime Torres Amate jtamate at
Tue Jul 5 18:37:30 CEST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for Calligra.


Quoting the w3 consortium:
[Definition: All text that is not markup constitutes the character data of the document.]

And in section

In editing XML documents, it is often convenient to use "white space" (spaces, tabs, and blank lines) to set apart the markup for greater readability. 
Such white space is typically not intended for inclusion in the delivered version of the document. 
On the other hand, "significant" white space that should be preserved in the delivered version is common, for example in poetry and source code.

An XML processor MUST always pass all characters in a document that are not markup through to the application. 
A  validating XML processor MUST also inform the application which of these characters constitute white space appearing in element content.

[Definition: An element type has mixed content when elements of that type may contain character data, optionally interspersed with child elements.] 
The attached patch modifies the xml parser to return the spaces between > and < as text elements.

I needed to change the TestXmlReader to remove all the additional spaces between nodes.
(I'll need to modify the patch to remove all the additional spaces I've introduced).


  libs/odf/KoXmlReader.cpp ad5e9d2 
  libs/odf/KoXmlReaderForward.h 4ca9a74 
  libs/odf/tests/TestXmlReader.cpp 6631b64 



The modified TestXmlReader test is OK.
There are only 2 regressions in the tests that I do not know how to fix:
        147 - krita-ui-KisKraLoaderTest (Failed)
        148 - krita-ui-KisKraSaverTest (Failed)

Also, I've been able to read with calligrawords and calligrastage all the .od* that I have without problems.


Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the calligra-devel mailing list