Review Request: Review request for tagging functionality in the branch krita_resource-management-tagging-tiyyagura and also merging this branch into master

Srikanth Tiyyagura srikanth.tulasiram at gmail.com
Sun Jul 3 16:04:06 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101793/
-----------------------------------------------------------

(Updated July 3, 2011, 3:04 p.m.)


Review request for Calligra.


Changes
-------

Added the unit test for KoResourceTagging Class; Changed the tool tips in GHNS tool bar

With these changes, I created a diff file and uploaded. Check this once . . !


Summary
-------

Tagging for the resources is completed and needs a review for merging into master. So, I created a diff file between master and krita_resource-management-tagging-tiyyagura branches and posted that here.

I think all the functionalities required are implemented; If I miss anything, please suggest me the ideas and I will implement them into tagging.


Diffs (updated)
-----

  krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 33e5310 
  krita/ui/kis_palette_manager.cpp e16d748 
  krita/ui/widgets/kis_gradient_chooser.cc 6852c0b 
  krita/ui/widgets/kis_paintop_presets_chooser_popup.h 557d1d5 
  krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp 54f7bc0 
  krita/ui/widgets/kis_pattern_chooser.cc 4a08ea9 
  krita/ui/widgets/kis_preset_chooser.h a27dfaa 
  krita/ui/widgets/kis_preset_chooser.cpp 30b624c 
  libs/widgets/CMakeLists.txt 6ff1df9 
  libs/widgets/KoResourceItemChooser.h 245e727 
  libs/widgets/KoResourceItemChooser.cpp 5ef3d63 
  libs/widgets/KoResourceServer.h fbae66e 
  libs/widgets/KoResourceServerAdapter.h 5422fe3 
  libs/widgets/KoResourceTagging.h PRE-CREATION 
  libs/widgets/KoResourceTagging.cpp PRE-CREATION 
  libs/widgets/tests/CMakeLists.txt 6be99cb 
  libs/widgets/tests/KoResourceTagging_test.h PRE-CREATION 
  libs/widgets/tests/KoResourceTagging_test.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101793/diff


Testing
-------


Thanks,

Srikanth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110703/2ef2ce5c/attachment.htm>


More information about the calligra-devel mailing list