Review Request: Adding XYZ Colorspace get/set convenient methods , compiles fine, but testing not done

Cyrille Berger Skott cyb at lepi.org
Sun Jul 3 10:37:44 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101826/#review4343
-----------------------------------------------------------

Ship it!


Before commiting, please fix the indentation of the functions, they are four spaces too much on the right.

- Cyrille


On July 2, 2011, 3:41 p.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101826/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 3:41 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Adding XYZ Colorspace get/set convenient methods
> 
> 
> Diffs
> -----
> 
>   libs/pigment/KoColorSpaceTraits.h 7214c78 
> 
> Diff: http://git.reviewboard.kde.org/r/101826/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Siddharth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110703/7df42909/attachment.htm>


More information about the calligra-devel mailing list