Review Request: add const qualifier to methods that do not modify the object status

Jaime Torres Amate jtamate at gmail.com
Sun Jul 3 09:04:57 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101839/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

Help the compiler to produce better code in methods that not modify the object members.
Also noticed that there is a duplicated class in two places.


Diffs
-----

  filters/karbon/ai/ailexer.h 66b9ac0 
  filters/karbon/ai/ailexer.cc b550294 
  filters/karbon/eps/pscommentlexer.h d6c949d 
  filters/karbon/eps/pscommentlexer.cc fa25d50 
  filters/libmso/writer.h 71bf67f 
  filters/libmso/writer.cpp 6a0c621 
  filters/tables/excel/sidewinder/value.cpp a0fae48 
  filters/tables/xlsx/XlsxXmlWorksheetReader_p.h b348997 
  filters/words/amipro/amiproparser.h 1556779 
  filters/words/html/import/kwdwriter.h 1e18403 
  filters/words/html/import/kwdwriter.cpp e20f8b3 
  filters/words/msword-odf/wv2/src/word_helper.h 62fcc89 
  filters/words/palmdoc/palmdb.h 527275f 
  filters/words/palmdoc/palmdoc.h d886b67 
  filters/words/wordperfect/import/ListStyle.hxx 24959c2 

Diff: http://git.reviewboard.kde.org/r/101839/diff


Testing
-------

same test failed as before.


Thanks,

Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110703/a3205e0d/attachment.htm>


More information about the calligra-devel mailing list