Review Request: Complete support for ODF glue points

[Jan Hambrecht]

> On Jan. 27, 2011, 6:23 a.m., Thorsten Zachmann wrote:
> > Some things I notices when testing
> > 
> > -I'm did not find out on how to create new connections between shapes.
> > -When clicking on a connection point to select it the options are disabled
> > 
> > Your patch fixes bug 251529
> > 
> > Thorsten

Hmm well, that's embarrassing. Creating new connections used to work, honest! For editing connection points, you first have to click on the shape which owns them. Then you can edit single connection points. Please watch the text in the status bar in Karbon, it tells you exactly what to do.
And yes I know it fixes bug 251529, it is written in the header of this review. :-)
Anyway, thanks for the review so far. I will post an updated patch.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100447/#review1087
-----------------------------------------------------------


On Jan. 26, 2011, 10:48 p.m., Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100447/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2011, 10:48 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch properly implements support for odf glue points (=connection points in flake) as defined in the ODF specification.
> The following are some of the main points tackled:
> 
> * a new struct KoConnectionPoint which holds the relevant data of a connection point
> * some new API in KoShape to handle connection points
> * loading of custom connection points and their attributes like escape direction and align
> * saving of connection points
> * huge improvement to the connection tool which now can also create, delete and edit connection points
> 
> 
> This addresses bug 251529.
>     http://bugs.kde.org/show_bug.cgi?id=251529
> 
> 
> Diffs
> -----
> 
>   kexi/shapes/relationdesign/kexirelationdesignshape.cpp 27604d4 
>   libs/flake/CMakeLists.txt 0447004 
>   libs/flake/KoConnectionPoint.h PRE-CREATION 
>   libs/flake/KoConnectionPoint.cpp PRE-CREATION 
>   libs/flake/KoConnectionShape.h 862d41b 
>   libs/flake/KoConnectionShape.cpp 8430eb0 
>   libs/flake/KoConnectionShapeLoadingUpdater.cpp 0bd834c 
>   libs/flake/KoConnectionShape_p.h ea3b0ba 
>   libs/flake/KoOdfWorkaround.h e6a5c63 
>   libs/flake/KoOdfWorkaround.cpp 36fd86b 
>   libs/flake/KoShape.h f7179d7 
>   libs/flake/KoShape.cpp c5aee86 
>   libs/flake/KoShape_p.h f52ba8c 
>   libs/flake/KoTextOnShapeContainer.cpp 07921ca 
>   libs/flake/tools/KoParameterChangeStrategy.h a10e54f 
>   libs/flake/tools/KoParameterChangeStrategy.cpp 925602f 
>   libs/flake/tools/KoParameterChangeStrategy_p.h PRE-CREATION 
>   libs/flake/tools/KoPathConnectionPointStrategy.h 2ec9467 
>   libs/flake/tools/KoPathConnectionPointStrategy.cpp 15764bc 
>   libs/flake/tools/KoPathConnectionPointStrategy_p.h PRE-CREATION 
>   libs/flake/tools/KoPathTool.h c863f11 
>   libs/flake/tools/KoPathTool.cpp fe9351a 
>   plugins/defaultTools/CMakeLists.txt 7bd62ce 
>   plugins/defaultTools/connectionTool/AddConnectionPointCommand.h PRE-CREATION 
>   plugins/defaultTools/connectionTool/AddConnectionPointCommand.cpp PRE-CREATION 
>   plugins/defaultTools/connectionTool/ChangeConnectionPointCommand.h PRE-CREATION 
>   plugins/defaultTools/connectionTool/ChangeConnectionPointCommand.cpp PRE-CREATION 
>   plugins/defaultTools/connectionTool/ConnectionPointWidget.h PRE-CREATION 
>   plugins/defaultTools/connectionTool/ConnectionPointWidget.cpp PRE-CREATION 
>   plugins/defaultTools/connectionTool/ConnectionPointWidget.ui PRE-CREATION 
>   plugins/defaultTools/connectionTool/ConnectionTool.h c0af323 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp a25b0d7 
>   plugins/defaultTools/connectionTool/ConnectionToolWidget.h 17e072e 
>   plugins/defaultTools/connectionTool/ConnectionToolWidget.cpp d7211ad 
>   plugins/defaultTools/connectionTool/ConnectionToolWidget.ui 6249ba4 
>   plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.h PRE-CREATION 
>   plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.cpp PRE-CREATION 
>   plugins/defaultTools/connectionTool/RemoveConnectionPointCommand.h PRE-CREATION 
>   plugins/defaultTools/connectionTool/RemoveConnectionPointCommand.cpp PRE-CREATION 
>   plugins/defaultTools/pics/CMakeLists.txt c64a256 
>   plugins/defaultTools/pics/hi16-action-escape-direction-all.png PRE-CREATION 
>   plugins/defaultTools/pics/hi16-action-escape-direction-down.png PRE-CREATION 
>   plugins/defaultTools/pics/hi16-action-escape-direction-horizontal.png PRE-CREATION 
>   plugins/defaultTools/pics/hi16-action-escape-direction-left.png PRE-CREATION 
>   plugins/defaultTools/pics/hi16-action-escape-direction-right.png PRE-CREATION 
>   plugins/defaultTools/pics/hi16-action-escape-direction-up.png PRE-CREATION 
>   plugins/defaultTools/pics/hi16-action-escape-direction-vertical.png PRE-CREATION 
>   plugins/treeshape/Layout.cpp 3b1a7ea 
>   plugins/treeshape/TreeShapeMoveStrategy.cpp cf20400 
> 
> Diff: http://git.reviewboard.kde.org/r/100447/diff
> 
> 
> Testing
> -------
> 
> Tested with the document attached to the bug report as well as with documents created with LibreOffice.
> 
> 
> Thanks,
> 
> Jan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110127/4ed33cae/attachment.htm>