Review Request: Send progress updates more frequently

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100438/#review1044
-----------------------------------------------------------


I'm not sure this is a good idea -- Jos added this code this summer to improve performance. A smoother progress update means slower loading because of the increased number of gui updates.

Maybe we should first get numbers on the performance difference?

- Boudewijn


On Jan. 24, 2011, 4:33 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100438/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2011, 4:33 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Send progress updates more frequently. There is already a limitation on what is send to the user in KoProgressUpdater that only sends updates only every 0.1 second. Without the change it can happen that the progress is only reported every 0.4 seconds. With this change the progress bar advances more smooth and does not jump as without the change
> 
> 
> Diffs
> -----
> 
>   libs/main/KoUpdater.cpp 8ea5fce 
>   libs/main/KoUpdaterPrivate_p.h af82419 
> 
> Diff: http://git.reviewboard.kde.org/r/100438/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorsten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110124/8d61fc85/attachment.htm>