Review Request: Configuration dialogs for Calligra Applications

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100406/#review992
-----------------------------------------------------------



libs/main/KoConfigurationDialogPage.h
<http://git.reviewboard.kde.org/r/100406/#comment800>

    There should be no space before the opening bracket 
    so  
    
    KoConfigurationDialogPage (QWidget* parent = 0); 
    
    should become
    
    KoConfigurationDialogPage(QWidget* parent = 0);
    
    Please fix that at all places where it is used



libs/main/dialogs/KoConfigurationDialog.h
<http://git.reviewboard.kde.org/r/100406/#comment802>

    Is it possible to use QWidget instead of KoView here? I did not see that KoView was used.



libs/main/dialogs/KoOpenSaveConfigurationDialogPage.cpp
<http://git.reviewboard.kde.org/r/100406/#comment803>

    is the title a user visible string. If so it should be put into a i18n()


- Thorsten


On Jan. 17, 2011, 5:46 p.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100406/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 5:46 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Currently there is no standard way to add configuration options that can apply calligra-wide to all applications. An example can be the auto-save delay, or default language.
> This patch adds the common configuration dialog to libs/main/. If I am proceeding in the right direction, I will change tables to use this system, and update this patch so it can then be merged.
> 
> 
> Diffs
> -----
> 
>   libs/main/CMakeLists.txt 457de07 
>   libs/main/KoConfigurationDialogPage.h PRE-CREATION 
>   libs/main/KoConfigurationDialogPage.cpp PRE-CREATION 
>   libs/main/KoView.h 7dfb232 
>   libs/main/KoView.cpp b09603d 
>   libs/main/dialogs/KoConfigurationDialog.h PRE-CREATION 
>   libs/main/dialogs/KoConfigurationDialog.cpp PRE-CREATION 
>   libs/main/dialogs/KoOpenSaveConfigurationDialogPage.h PRE-CREATION 
>   libs/main/dialogs/KoOpenSaveConfigurationDialogPage.cpp PRE-CREATION 
>   libs/main/dialogs/KoOpenSaveConfigurationWidget.ui PRE-CREATION 
>   tables/part/View.h a542637 
>   tables/part/View.cpp 8b9ba78 
>   tables/tables.rc 0fde1b6 
> 
> Diff: http://git.reviewboard.kde.org/r/100406/diff
> 
> 
> Testing
> -------
> 
> A sample in tables/part/view.cpp shows that this works as expected. By compiling and running this, we see two "Configure Tables" options in calligratables, the new one is the second one. Upon selecting that, a dialog appears with the common "Open/Save" page from libs/main/dialogs/ and a custom page added from Tables.
> 
> 
> Screenshots
> -----------
> 
> Common Save/Open page
>   http://git.reviewboard.kde.org/r/100406/s/48/
> Custom page added by tables
>   http://git.reviewboard.kde.org/r/100406/s/49/
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110119/fd1a0c34/attachment.htm>