Review Request: Added creation and processing of a text style to format the number/bullet of a list.

[Matus Uzak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100306/
-----------------------------------------------------------

(Updated Jan. 9, 2011, 10:11 p.m.)


Review request for Calligra.


Changes
-------

* Incorporated review comments.
* Added screen shots of OpenOffice displaying the test file.


Summary
-------

Filter changes:
* Let's use the style-name attribute of a list-level-style-* to point to a text style, which should be used to format the bullet/number of a list.
* The style is stored into office:styles to be accessible via the style manager during layout.

KoListLevelProperties changes:
* Lookup the referred style using the style manager and update the CharacterStyleId of the KoListStyle.

TODO:
* If this approach is correct, also other filters should be updated.
* Bullet sizes! 


Diffs (updated)
-----

  filters/words/msword-odf/texthandler.h 1465e66 
  filters/words/msword-odf/texthandler.cpp b7d582c 
  libs/kotext/styles/KoListLevelProperties.cpp ec5a472 

Diff: http://git.reviewboard.kde.org/r/100306/diff


Testing
-------

Using words application only, msword test documents containing numbered lists.


Screenshots
-----------

msword 2007
  http://git.reviewboard.kde.org/r/100306/s/33/
words
  http://git.reviewboard.kde.org/r/100306/s/34/
words patched
  http://git.reviewboard.kde.org/r/100306/s/35/
msword (list item sizes)
  http://git.reviewboard.kde.org/r/100306/s/36/
words (list item sizes)
  http://git.reviewboard.kde.org/r/100306/s/37/
OO displaying current mswordodf filter output
  http://git.reviewboard.kde.org/r/100306/s/40/
OO (patched mswordodf filter output)
  http://git.reviewboard.kde.org/r/100306/s/41/


Thanks,

Matus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110109/7912d768/attachment.htm>