Review Request: Added creation and processing of a text style to format the number/bullet of a list.

Matus Uzak matus.uzak at ixonos.com
Fri Jan 7 13:05:58 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100306/
-----------------------------------------------------------

(Updated 2011-01-07 13:05:58.101875)


Review request for Calligra.


Changes
-------

* Incorporated review comments.
* Added loading of the "bullet-relative-size" attribute in KoListLevelProperties::loadOdf function.


Summary
-------

Filter changes:
* Let's use the style-name attribute of a list-level-style-* to point to a text style, which should be used to format the bullet/number of a list.
* The style is stored into office:styles to be accessible via the style manager during layout.

KoListLevelProperties changes:
* Lookup the referred style using the style manager and update the CharacterStyleId of the KoListStyle.

TODO:
* If this approach is correct, also other filters should be updated.
* Bullet sizes! 


Diffs (updated)
-----

  filters/words/msword-odf/texthandler.h 1465e66 
  filters/words/msword-odf/texthandler.cpp 96de97d 
  libs/kotext/styles/KoListLevelProperties.cpp ec5a472 

Diff: http://git.reviewboard.kde.org/r/100306/diff


Testing
-------

Using words application only, msword test documents containing numbered lists.


Thanks,

Matus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110107/d12e73a9/attachment.htm>


More information about the calligra-devel mailing list