Review Request: Rename the "table" shape to spreadsheet shape

Marijn Kruisselbrink m.kruisselbrink at student.tue.nl
Mon Jan 3 23:02:11 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100299/#review721
-----------------------------------------------------------

Ship it!


Agree

- Marijn


On 2011-01-03 21:04:36, Cyrille Berger Skott wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100299/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 21:04:36)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Summary
> -------
> 
> As you can see in http://forum.kde.org/viewtopic.php?f=96&t=92343 the table shape is confused for a text table shape, while it is really a spreadsheet shape. I am suggesting we make it clear to the user that it is a spreadsheet shape.
> 
> 
> Diffs
> -----
> 
>   tables/shape/TableShapeFactory.cpp 84b3901e76678f61483a5d7800a4d69889418835 
> 
> Diff: http://git.reviewboard.kde.org/r/100299/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cyrille
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110103/11233feb/attachment.htm>


More information about the calligra-devel mailing list