Review Request: Define LIBWPD_VERSION_MINOR in the correct place.

Cyrille Berger Skott cyb at lepi.org
Sun Jan 2 22:04:49 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100287/#review702
-----------------------------------------------------------

Ship it!


Thanks commited.

- Cyrille


On 2011-01-02 17:38:43, Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100287/
> -----------------------------------------------------------
> 
> (Updated 2011-01-02 17:38:43)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Give libwpd/libwpd.h a chance to define LIBWPD_VERSION_MINOR before the #ifndef check. Otherwise, it will lead to redefinition warnings.
> 
> 
> Diffs
> -----
> 
>   filters/words/wordperfect/import/wpimport.cc 6e07a97 
> 
> Diff: http://git.reviewboard.kde.org/r/100287/diff
> 
> 
> Testing
> -------
> 
> None. The patch is trivial.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110102/98c36495/attachment.htm>


More information about the calligra-devel mailing list