Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100716/#review1603
-----------------------------------------------------------


When testing the page for me the preview of the file was always very small. See http://www.zagge.de/files/imageselector.png for what I mean. Even if resized the next time it was small again. Maybe you can make the preview as big as the file dialog at least. 

On a related note: I don't like the preview widget at all. Isn't there a possibility to show the preview inline in the dialog so that you are still able to choose a different file if e.g. you pressed on the wrong file. Currently that is not possible. And requires you to start from the beginning.

- Thorsten


On Feb. 22, 2011, 3:56 p.m., Marijn Kruisselbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100716/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2011, 3:56 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This changes KoImageSelectionWidget to no longer be a widget that embeds a KFileWidget, but instead show a KFileDialog to select a file. This should make it for example feel more native when run on windows, as you get a real file dialog. The overall behavior of the widget hasn't really changed with this diff, after selecting a file in the dialog/widget, you still get a preview of the image and can Ok/Cancel it.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoImageSelectionWidget.h 737ffdc3f655eaffb31eeb569384fe2b6c8aa678 
>   libs/main/KoImageSelectionWidget.cpp 92c6d215b1a4c30607b1855dd517cfbce61bdda7 
> 
> Diff: http://git.reviewboard.kde.org/r/100716/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marijn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110223/1b62024e/attachment.htm>