Review Request: Stage: Enhace behaviour of copy/paste slides in slide sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100672/#review1499
-----------------------------------------------------------


Hello Paul,

Ctrl + C and friends are standard actions. They can be used by edit_cut edit_copy edit_paste and edit_delete (for the delete action). The copy action is handled by the KoCopyController. I'm not 100% sure on how it can be used in the application but maybe it gets clear when you look at the class. The actions are initialized in KoPAView.cpp. I think edit paste should work out of the box but the others it might be more difficult as there is no special tool used for the slide sorter. If you can't find a solution maybe also ask on the mailing list if someone has an idea on how to make it work.

While testing the patch I noticed the following behaviour.

If I left click on a slide that was not selected before it gets selected.
If I then use delete/cut the first slide/previously selected slide instead of the selected one.

One additional think I noticed is that it is not possible if you have 5 slides in 2 rows (3 in the first and 2 in the second) it is not possible to move the selected slide to the end of the slides. Maybe that is something you are interested to look into to.


kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1268>

    Please remove the blank before ) and after (.



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1269>

    There should be a blank before and after +


- Thorsten


On Feb. 17, 2011, 9:02 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100672/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2011, 9:02 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Correct how slides sorter updates when add/delete/copy/paste a slide. Add some copy/paste extra context menu, and the supr key for delete slides in slides sorter.
> 
> Any suggestion for add Contrl C/V/X support?
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrViewModeSlidesSorter.h 743fbe9 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 24e6c1e 
>   libs/kopageapp/KoPAView.h 55a6b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/100672/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110219/5891cd79/attachment.htm>