Review Request: Implement saving for the KoUnavailShape

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100629/
-----------------------------------------------------------

Review request for Calligra.


Changes
-------

Updated to fix nearly all issues found by Zagge.

This update merges the KoEmbeddedFileSaver into KoEmbeddedDocumentSaver.  It also removes many small changes to make the updated diff as small as possible against master.

The combined saver should be called KoEmbeddedObjectSaver, but that can be done after commit of the main code, according to Zagge.  I agree with that.

There is still one issue, though: The resulting saved file does not load into OOwriter again.  I have been racking my head why that is, but I can't find the reason.  The XML inside ODF seems correct. Perhaps somebody else can help me here?


Summary
-------

This patch implements saving in the KoUnavailShape.

The method it uses is to introduce a new class, KoEmbeddedFileSaver, in koodf. This class is a bit like the KoEmbeddedObjectSaver class, and is created and instantiated in the same places. It is also part of the KoShapeSavingContext.

As a bonus, this patch also implements saving for the Vector shape, since I used that for testing in early stages.


Diffs (updated)
-----

  libs/flake/KoDrag.cpp 8ed2656 
  libs/flake/KoDragOdfSaveHelper.cpp 727e6c5 
  libs/flake/KoShapeSavingContext.h a06e040 
  libs/flake/KoShapeSavingContext.cpp fd8fb41 
  libs/flake/KoUnavailShape.cpp 3f10acf 
  libs/kopageapp/KoPAOdfPageSaveHelper.h d8f064a 
  libs/kopageapp/KoPAOdfPageSaveHelper.cpp c60d0d8 
  libs/kopageapp/KoPAPastePage.cpp 01bafe0 
  libs/kopageapp/KoPASavingContext.h c678e2c 
  libs/kopageapp/KoPASavingContext.cpp 52524bf 
  libs/kotext/KoTextDrag.cpp f30cb5c 
  libs/kotext/KoTextOdfSaveHelper.h 155aecd 
  libs/kotext/KoTextOdfSaveHelper.cpp d012557 
  libs/kotext/KoTextShapeSavingContext.h 4d27bc4 
  libs/kotext/KoTextShapeSavingContext.cpp d5ade20 
  libs/kotext/opendocument/tests/TestChangeLoading.cpp ac42ddd 
  libs/kotext/opendocument/tests/TestLoading.cpp e6a790a 
  libs/main/KoDocument.cpp 956e179 
  libs/odf/CMakeLists.txt 1a6a131 
  libs/odf/KoEmbeddedDocumentSaver.h 11cf075 
  libs/odf/KoEmbeddedDocumentSaver.cpp a8e13d8 
  libs/odf/KoOdfDocument.h c242776 
  libs/odf/KoOdfLoadingContext.h 023b92f 
  libs/odf/KoOdfLoadingContext.cpp ce53992 
  libs/odf/KoOdfManifest.h PRE-CREATION 
  libs/odf/KoOdfManifest.cpp PRE-CREATION 
  plugins/vectorshape/VectorShape.cpp 9965d68 
  tables/Cell.cpp 7aa8306 

Diff: http://git.reviewboard.kde.org/r/100629/diff


Testing
-------

Tested with a simple odt file with an embedded spreadsheet.


Thanks,

Inge

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110218/7b313b13/attachment.htm>