Review Request: Stage: Enhace behaviour of copy/paste slides in slide sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100672/#review1469
-----------------------------------------------------------


Hello Paul,

yes the default actions Ctrl CVX would be best.

I could not test the patch as it did not apply. I think the patch contains some stuff of the previous stuff you worked on and therefore it does no longer apply. Can you please update the patch.

Thorsten


kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1233>

    Please remove the blank after ( and before )



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1234>

    When using dynamic_cast you should also check that the return value is valid before using it.



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1235>

    would it be possible to handle this a bit more intelligent instead of recreating all slides again which can be quite expensive if there are a lot of slides. It is not needed for getting this patch in but I think that is something to improve with a later commit.


- Thorsten


On Feb. 16, 2011, 10:22 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100672/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 10:22 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Correct how slides sorter updates when add/delete/copy/paste a slide. Add some copy/paste extra context menu, and the supr key for delete slides in slides sorter.
> 
> Any suggestion for add Contrl C/V/X support?
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPAView.h 55a6b7d 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp ff1d737 
>   kpresenter/part/KPrViewModeSlidesSorter.h 724ee1d 
> 
> Diff: http://git.reviewboard.kde.org/r/100672/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110217/a53ee3dc/attachment.htm>