Review Request: Stages slides sorter patch

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100648/#review1452
-----------------------------------------------------------

Ship it!


Please fix the additional comments and then commit. If you don't have commit rights you can send my the patch and I can commit it for you.

One thing that might interest you working on is that when copy and paste or delete a shape while in slide sorter the page is not added/removed from the slides sorter. Also support for the del key to delete the currently selected slide would be nice.


kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1214>

    Please move the code up so that it is directly under the code that initializes the showStatusbarAction



kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1212>

    in setChecked you can use true. No need to check if viewMode() == m_normalMode as it is set just above.



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1216>

    There should be no blank after the ( and before the )


- Thorsten


On Feb. 15, 2011, 8:32 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100648/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2011, 8:32 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Review of the slides sorter patch for Stages, to add double click return to normal view
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp ff1d737 
>   kpresenter/part/KPrViewModeSlidesSorter.h 724ee1d 
>   kpresenter/part/KPrView.h a59bf08 
>   kpresenter/part/KPrView.cpp e624990 
> 
> Diff: http://git.reviewboard.kde.org/r/100648/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110216/b6c41f7e/attachment.htm>