Review Request: Stages slides sorter patch

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100648/#review1424
-----------------------------------------------------------


Nice work. Thanks.

When testing the patch I found a crash. To reprouce do the following:

- Select slide sorter mode
- Double click on a slide (bings you back to normal mode)
- Select slide sorter mode 
-> Crash with the following backtrace

Thread 1 (Thread 0x7fac860fc7a0 (LWP 8252)):
[KCrash Handler]
#6  0x00007fac7fbc5ba5 in raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#7  0x00007fac7fbc96b0 in abort () at abort.c:92
#8  0x00007fac8099b864 in qt_message_output (msgType=QtFatalMsg, buf=<value optimized out>) at global/qglobal.cpp:2259
#9  0x00007fac8099ba42 in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7fac80afe098 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7ffff55a10b0) at global/qglobal.cpp:2305
#10 0x00007fac8099bbf5 in qFatal (msg=0x203c <Address 0x203c out of bounds>) at global/qglobal.cpp:2488
#11 0x00007fac6f702385 in QList<KoPAPageBase*>::at (this=0x1d77bc0, i=-1) at /usr/include/qt4/QtCore/qlist.h:455
#12 0x00007fac6f6fedc9 in KoPADocument::pageByIndex (this=0x1c8ebd0, index=-1, masterPage=false) at /home/tz/develop/kde/git/calligra/libs/kopageapp/KoPADocument.cpp:437
#13 0x00007fac6f9a5793 in KPrViewModeSlidesSorter::updateDocumentDock (this=0x5d0a070) at /home/tz/develop/kde/git/calligra/kpresenter/part/KPrViewModeSlidesSorter.cpp:203
#14 0x00007fac6f9909cc in KPrViewModeSlidesSorter::qt_metacall (this=0x5d0a070, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7ffff55a1330) at /home/ko2/calligra-build/kpresenter/part/moc_KPrViewModeSlidesSorter.cpp:72
#15 0x00007fac80aafb27 in QMetaObject::activate (sender=0x5c83ad0, m=<value optimized out>, local_signal_index=<value optimized out>, argv=0xffffffffffffffff) at kernel/qobject.cpp:3280
#16 0x00007fac81c8f6c1 in QListWidget::currentRowChanged (this=0x203c, _t1=-1) at .moc/release-shared/moc_qlistwidget.cpp:247
#17 0x00007fac81c91249 in QListWidgetPrivate::_q_emitCurrentItemChanged (this=<value optimized out>, current=<value optimized out>, previous=<value optimized out>) at itemviews/qlistwidget.cpp:1121
#18 0x00007fac81c93e2d in QListWidget::qt_metacall (this=0x5c83ad0, _c=QMetaObject::InvokeMetaMethod, _id=<value optimized out>, _a=0x7ffff55a14d0) at .moc/release-shared/moc_qlistwidget.cpp:147
#19 0x00007fac80aafb27 in QMetaObject::activate (sender=0x5d3da10, m=<value optimized out>, local_signal_index=<value optimized out>, argv=0xffffffffffffffff) at kernel/qobject.cpp:3280
#20 0x00007fac81c7b61a in QItemSelectionModel::currentChanged (this=0x203c, _t1=<value optimized out>, _t2=<value optimized out>) at .moc/release-shared/moc_qitemselectionmodel.cpp:159
#21 0x00007fac81c7f903 in QItemSelectionModel::clear (this=0x5d3da10) at itemviews/qitemselectionmodel.cpp:1101
#22 0x00007fac81c91d73 in QListWidget::clear (this=<value optimized out>) at itemviews/qlistwidget.cpp:1751
#23 0x00007fac6f9a5c1d in KPrViewModeSlidesSorter::populate (this=0x5d0a070) at /home/tz/develop/kde/git/calligra/kpresenter/part/KPrViewModeSlidesSorter.cpp:304
#24 0x00007fac6f9a5457 in KPrViewModeSlidesSorter::activate (this=0x5d0a070, previousViewMode=0x5be3d40) at /home/tz/develop/kde/git/calligra/kpresenter/part/KPrViewModeSlidesSorter.cpp:168
#25 0x00007fac6f70df7d in KoPAViewBase::setViewMode (this=0x24d2cc0, mode=0x5d0a070) at /home/tz/develop/kde/git/calligra/libs/kopageapp/KoPAViewBase.cpp:76
#26 0x00007fac6f99f4ad in KPrView::showSlidesSorter (this=0x24d2c80) at /home/tz/develop/kde/git/calligra/kpresenter/part/KPrView.cpp:369
...


kpresenter/part/KPrView.h
<http://git.reviewboard.kde.org/r/100648/#comment1187>

    The two methods are not needed



kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1188>

    The singleShot is not needed here, please put the code to enable/disable the statusbar behind the code that creates the statusbar some lines above



kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1189>

    The singleShot is not needed here. Please put the code to set the normal mode directly here.



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1193>

    please remove the " " after the ( and before the ).



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1190>

    Please remove the " " after the ( and before the )



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1191>

    the indention is wrong here. Please use 4 spaces



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100648/#comment1192>

    I think a static_cast should work here to.


- Thorsten


On Feb. 13, 2011, 6:07 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100648/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2011, 6:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Review of the slides sorter patch for Stages, to add double click return to normal view
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrView.h a59bf08 
>   kpresenter/part/KPrView.cpp e624990 
>   kpresenter/part/KPrViewModeSlidesSorter.h 724ee1d 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp ff1d737 
> 
> Diff: http://git.reviewboard.kde.org/r/100648/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110214/b94bed9d/attachment.htm>