invalid odf

Thorsten Zachmann t.zachmann at zagge.de
Sun Feb 13 05:25:06 GMT 2011


Hello Casper,

while testing ingwas unavail patch I found out that we produce invalid odf. 
The code that creates the invalid odf was added by the follwoing commit.

eb81a367    (Casper Boemann 2010-12-28 13:20:39 +0100   1823)        
context.xmlWriter().addAttribute("style:wrap", value);                                                                   
eb81a367    (Casper Boemann 2010-12-28 13:20:39 +0100   1824)                                                                                                                                 
eb81a367    (Casper Boemann 2010-12-28 13:20:39 +0100   1825)        
context.xmlWriter().addAttribute("fo:margin", 
QString::number(textRunAroundDistance()) + "pt");                          

The style:wrap and fo:margin must be saved as part if the  <style:graphic-
properties>

If you need help fixing this please let me know.

Maybe testing the odf we produce is something we should add to out automated 
testing. (We need to make sure to not alarm stuff we added as we need it).

Thorsten



More information about the calligra-devel mailing list