Review Request: Limit zooming to a minimum and maximum zoom value

Arjen Hiemstra djfreestyler at gmail.com
Wed Feb 9 00:45:14 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

This bug fixes an issue with Calligra's zoom handling, caused by not limiting the minimum and maximum zoom levels. Currently it is possible to completely freeze Tables (or cause even more serious issues) by zoom out far enough.
Zooming in on the other hand can cause you to get completely lost in your document.

Note that for Krita and others, the default minimum and maximum zoom might not be the best choice, which is why I included a setter for the minimum and maximum values.


Diffs
-----

  libs/widgets/KoZoomAction.cpp 4ef4d8b 
  libs/widgets/KoZoomController.cpp 54b9168 
  libs/widgets/KoZoomHandler.cpp ce234e6 
  libs/widgets/KoZoomMode.h 9bfd195 
  libs/widgets/KoZoomMode.cpp 293f1af 

Diff: http://git.reviewboard.kde.org/r/100613/diff


Testing
-------

Tested on Words, Stage, Tables and Krita. This patch currently breaks the zoom handler unit test, which I will fix after this.


Thanks,

Arjen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110209/98b67d28/attachment.htm>


More information about the calligra-devel mailing list