Review Request: Switch tool actions on tool change

[Sven Langkamp]

> On Feb. 2, 2011, 6:54 p.m., Boudewijn Rempt wrote:
> > I like it, also because it removes another hard-coded dependency on KoCanvasControllerWidget.

On IRC Cyrille suggested to pass the action collection to the constructor. I will change that and then update the patch.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100508/#review1162
-----------------------------------------------------------


On Feb. 1, 2011, 1:14 p.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100508/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2011, 1:14 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Currently there is a problem when you switch the input device to tablet. By default only the actions for the mouse input device are in the action collection. After switching the input device the tool is changed, but the new actions are not added to the action collection.
> 
> With the patch the actions of the old tool are taken form the action collection and the new added. Also copies the shortcuts as they might have changed.
> Applications that want to use this have to provide an action collection in the canvas controller.
> 
> 
> This addresses bug 258066.
>     http://bugs.kde.org/show_bug.cgi?id=258066
> 
> 
> Diffs
> -----
> 
>   krita/ui/kis_view2.cpp 037a110 
>   libs/flake/KoCanvasController.h 317548d 
>   libs/flake/KoCanvasController.cpp 21d5f8a 
>   libs/flake/KoToolManager.cpp 2db9bc1 
>   libs/flake/KoToolManager_p.h 8ec6614 
> 
> Diff: http://git.reviewboard.kde.org/r/100508/diff
> 
> 
> Testing
> -------
> 
> Fixes bug 258066.
> 
> 
> Thanks,
> 
> Sven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110202/9e5ca92e/attachment.htm>