Review Request: Send progress updates more frequently

Boudewijn Rempt boud at valdyas.org
Tue Feb 1 07:45:23 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100438/#review1136
-----------------------------------------------------------



libs/main/KoUpdater.cpp
<http://git.reviewboard.kde.org/r/100438/#comment957>

    I think I must be missing something -- shouldn't this be dependent on hasOutput?


- Boudewijn


On Feb. 1, 2011, 4:01 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100438/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2011, 4:01 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Send progress updates more frequently. There is already a limitation on what is send to the user in KoProgressUpdater that only sends updates only every 0.1 second. Without the change it can happen that the progress is only reported every 0.4 seconds. With this change the progress bar advances more smooth and does not jump as without the change
> 
> 
> Diffs
> -----
> 
>   libs/main/KoProgressUpdater.h be5fbef 
>   libs/main/KoProgressUpdater.cpp 207bb36 
>   libs/main/KoUpdater.cpp 8ea5fce 
>   libs/main/KoUpdaterPrivate_p.h af82419 
> 
> Diff: http://git.reviewboard.kde.org/r/100438/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorsten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110201/73cc5068/attachment.htm>


More information about the calligra-devel mailing list