Review Request: Add config option to make grid shown behind the shapes in kopageapp

[Jarosław Staniek]

> On Dec. 21, 2011, 8:55 a.m., Jan Hambrecht wrote:
> > As Jaroslaw correctly pointed out, it should not be a user visible option. If you decide to paint the grid behind shapes for flow/stage, then just do that. With your patch all applications using the grid config page would have that option present in their configuration dialog, even if they are not using that flag in any way.

Jan added one point extra to that. 

To be constructive: I've long ago planned to have about:config GUI [1] for Kexi since I understand rare needs for tweaking (and tweaking per-document sometimes rather than per app). 

I would put such advanced settings in the about:config, keeping them in a good hierarchy, why not. Until I have this feature I tend to choose good defaults suitable for given context and eventually if really really needed - I am adding setting to a *rc file and somewhat document it so the meaning is well defined.

[1] http://www.askdavetaylor.com/1-blog-pics/firefox-about-config.png


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103483/#review9133
-----------------------------------------------------------


On Dec. 21, 2011, 4:36 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103483/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 4:36 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Add config option to make grid shown behind the shapes in kopageapp, one new option added in Settings -> Configure -> Grid.
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPAViewModeNormal.cpp 7402f3f 
>   libs/main/KoGridData.h 296c812 
>   libs/main/KoGridData.cpp f37d36f 
>   libs/main/config/KoConfigGridPage.cpp a3e1d6f 
> 
> Diff: http://git.reviewboard.kde.org/r/103483/diff/diff
> 
> 
> Testing
> -------
> 
> works well, no problem found.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111221/66ff5f01/attachment.htm>