Review Request: Fix bug with zero scale of the brush in krita

Boudewijn Rempt boud at valdyas.org
Sun Dec 18 12:44:49 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103445/#review9038
-----------------------------------------------------------

Ship it!


Looks good to me.

- Boudewijn Rempt


On Dec. 18, 2011, 11:20 a.m., Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103445/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 11:20 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When using tablet, the last events coming from it are almost zero, so the resulting scale is zero as well. Default mask generator will get crazy if it gets zero scale due to division by zero. So we need to check in most of the tools whether the scale is zero.
> 
> 
> This addresses bug 289145.
>     http://bugs.kde.org/show_bug.cgi?id=289145
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/complexop/kis_complexop.cpp b0742ea 
>   krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp 9a2d75a 
>   krita/plugins/paintops/deform/kis_deform_paintop.cpp e8c1f51 
>   krita/plugins/paintops/hairy/kis_hairy_paintop.cpp b6c2773 
>   krita/plugins/paintops/sketch/kis_sketch_paintop.cpp 0a86895 
>   krita/plugins/paintops/spray/kis_spray_paintop.cpp 4d8a6f2 
> 
> Diff: http://git.reviewboard.kde.org/r/103445/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Kazakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111218/b3baa84a/attachment.htm>


More information about the calligra-devel mailing list