Review Request: Clean a bit calligraconverter.cpp

Alex Fiestas alex at eyeos.org
Wed Dec 14 19:28:24 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103413/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Cleaned a little bit calligraconverter.cpp by applying some general code clean concepts such:
Return early
Return on errors
Do one thing on each function

Is not much change but I think makes code clearer with less indentation etc.


Diffs
-----

  tools/converter/calligraconverter.cpp 1baea00 

Diff: http://git.reviewboard.kde.org/r/103413/diff/diff


Testing
-------


Thanks,

Alex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111214/059d6ef4/attachment.htm>


More information about the calligra-devel mailing list