Review Request: kexi null pointer safeguards

Jaime Torres Amate jtamate at gmail.com
Sun Aug 28 12:55:09 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102474/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

Add null pointer safeguards
Initialize some variables that could be used uninitialized
change a parameter to be passed by reference


Diffs
-----

  kexi/formeditor/commands.cpp 0508a92 
  kexi/formeditor/editlistviewdialog.cpp 31245d1 
  kexi/kexidb/drivers/mySQL/mysqlconnection.cpp a5c8228 
  kexi/kexidb/drivers/oracle/oracleconnection.cpp 7634c73 
  kexi/kexidb/drivers/oracle/oracleconnection_p.cpp 29bfe1f 
  kexi/kexidb/drivers/pqxx/pqxxconnection.cpp eb3029c 
  kexi/kexidb/drivers/sqlite/sqliteconnection.cpp 9c4e676 
  kexi/kexidb/drivers/sybase/sybaseconnection.cpp 32437f4 
  kexi/kexidb/drivers/xbase/xbaseconnection.cpp 351ac3d 
  kexi/kexidb/utils.h f941a08 
  kexi/main/KexiMainWindow.cpp 104849b 
  kexi/main/printing/kexisimpleprintingpagesetup.cpp 37f6fa2 
  kexi/plugins/forms/kexiformview.cpp 105b5f9 

Diff: http://git.reviewboard.kde.org/r/102474/diff


Testing
-------

no change in make test


Thanks,

Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110828/4433f749/attachment.htm>


More information about the calligra-devel mailing list