Review Request: Tables: Fix Bug 266223 - Cannot reliably sort rows with some empty cells

[Juan Aquino]

> On Aug. 23, 2011, 8:12 a.m., Sebastian Sauer wrote:
> > Boemann provided the answer; "in excel at least you can choose format even if the value is empty"
> > So, yes, makes absolutely sense :-)
> >
> 
> Juan Aquino wrote:
>     I have no git account, please commit for me.
> 
> Sebastian Sauer wrote:
>     Patch applied with 43e285d3. This, btw, is an amazing patch. Really great work! For the case you plan to continue to contribute in the future I would suggest to get a git account so you can pull+push yourself and maybe even work in a branch for a larger change or xyz... See http://community.kde.org/Sysadmin/GitKdeOrgManual#How_to_get_read-write_developer_access for details how to get read/write access for all of KDE including Calligra :-)
>

Thanks Seb, I'm working in the bugs 239721, 172490, I sent the patchs for these bugs and request a git account :)


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102411/#review5931
-----------------------------------------------------------


On Aug. 22, 2011, 6:41 p.m., Juan Aquino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102411/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 6:41 p.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.
> 
> 
> Summary
> -------
> 
> Calligra Tables.
> Fix Bug 266223 - Cannot reliably sort rows with some empty cells 
> 
> 
> This addresses bug 266223.
>     http://bugs.kde.org/show_bug.cgi?id=266223
> 
> 
> Diffs
> -----
> 
>   tables/commands/DataManipulators.cpp cdff69e 
>   tables/commands/SortManipulator.cpp ba57229 
>   tables/tests/CMakeLists.txt 6964f36 
>   tables/tests/TestSort.h PRE-CREATION 
>   tables/tests/TestSort.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102411/diff
> 
> 
> Testing
> -------
> 
> Test added.
> 
> 
> Thanks,
> 
> Juan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110824/53639efd/attachment.htm>