Review Request: Tables: Fix Bug 266223 - Cannot reliably sort rows with some empty cells

[Sebastian Sauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102411/#review5930
-----------------------------------------------------------



tables/commands/DataManipulators.cpp
<http://git.reviewboard.kde.org/r/102411/#comment5244>

    I am not sure about that one. Why is that needed? Can we have a cellformat != Format::None with an empty value?
    
    In any case if you think it's needed then maybe add a comment why? That will help the next one who has to deal with that particular code to understand why those lines are commented out.
    



tables/commands/SortManipulator.cpp
<http://git.reviewboard.kde.org/r/102411/#comment5243>

    Good catch


- Sebastian


On Aug. 22, 2011, 6:41 p.m., Juan Aquino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102411/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 6:41 p.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.
> 
> 
> Summary
> -------
> 
> Calligra Tables.
> Fix Bug 266223 - Cannot reliably sort rows with some empty cells 
> 
> 
> This addresses bug 266223.
>     http://bugs.kde.org/show_bug.cgi?id=266223
> 
> 
> Diffs
> -----
> 
>   tables/commands/DataManipulators.cpp cdff69e 
>   tables/commands/SortManipulator.cpp ba57229 
>   tables/tests/CMakeLists.txt 6964f36 
>   tables/tests/TestSort.h PRE-CREATION 
>   tables/tests/TestSort.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102411/diff
> 
> 
> Testing
> -------
> 
> Test added.
> 
> 
> Thanks,
> 
> Juan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110823/e6fa9a33/attachment.htm>