Review Request: The basic web widget in Kexi reports, put up for review.The widget is not yet painted on report canvas.Please suggest possible issues

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102046/#review5923
-----------------------------------------------------------



plugins/reporting/Web/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102046/#comment5216>

    no needed 4 lines?



plugins/reporting/Web/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102046/#comment5217>

    the file should be KoReportDesignerItemWeb.cpp



plugins/reporting/Web/KoReportDesignerItemweb.h
<http://git.reviewboard.kde.org/r/102046/#comment5223>

    rename the file to KoReportDesignerItemWeb.h



plugins/reporting/Web/KoReportDesignerItemweb.h
<http://git.reviewboard.kde.org/r/102046/#comment5218>

    please remove indent



plugins/reporting/Web/KoReportDesignerItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment5222>

    rename the file to KoReportDesignerItemWeb.cpp



plugins/reporting/Web/KoReportDesignerItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment5219>

    missing space 



plugins/reporting/Web/KoReportDesignerItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment5220>

    rename to "web"



plugins/reporting/Web/KoReportItemweb.h
<http://git.reviewboard.kde.org/r/102046/#comment5221>

    rename the file to KoReportItemWeb.h



plugins/reporting/Web/KoReportItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment5224>

    rename the file to KoReportItemWeb.cpp



plugins/reporting/Web/KoReportwebPlugin.h
<http://git.reviewboard.kde.org/r/102046/#comment5225>

    rename the file to KoReportWebPlugin.h
    
    Just always use CamelCase for .h and .cpp files!



plugins/reporting/Web/KoReportwebPlugin.cpp
<http://git.reviewboard.kde.org/r/102046/#comment5226>

    rename the file to KoReportWebPlugin.cpp



plugins/reporting/Web/koreport_webplugin.desktop
<http://git.reviewboard.kde.org/r/102046/#comment5227>

    should be koreport_webplugin, this is lib name


- Jarosław


On Aug. 21, 2011, 10:11 a.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102046/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2011, 10:11 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Summary
> -------
> 
> Have made the change in Desktop files and filenames have been changed to KoReportDesigneritemWeb etc. after uploading this.Please have a look as to where the mistake lies. 
> 
> 
> This addresses bug no.
>     http://bugs.kde.org/show_bug.cgi?id=no
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/Web/CMakeLists.txt PRE-CREATION 
>   plugins/reporting/Web/KoReportDesignerItemweb.h PRE-CREATION 
>   plugins/reporting/Web/KoReportDesignerItemweb.cpp PRE-CREATION 
>   plugins/reporting/Web/KoReportItemweb.h PRE-CREATION 
>   plugins/reporting/Web/KoReportItemweb.cpp PRE-CREATION 
>   plugins/reporting/Web/KoReportwebPlugin.h PRE-CREATION 
>   plugins/reporting/Web/KoReportwebPlugin.cpp PRE-CREATION 
>   plugins/reporting/Web/koreport_webplugin.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102046/diff
> 
> 
> Testing
> -------
> 
> built
> 
> 
> Thanks,
> 
> Shreya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110822/cde9bcb1/attachment.htm>