Review Request: Remove class KoPointGroup from flake

Thorsten Zachmann t.zachmann at zagge.de
Sun Aug 21 05:13:21 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102389/#review5864
-----------------------------------------------------------

Ship it!


Looks good.

- Thorsten


On Aug. 20, 2011, 4 p.m., Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102389/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2011, 4 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> The class KoPointGroup is not used anywhere in any meaningful way. Removing it does not remove any feature but makes the KoPathPoint class a little leaner.
> 
> 
> Diffs
> -----
> 
>   libs/flake/CMakeLists.txt b9f388f 
>   libs/flake/KoPathPoint.h 1ba4314 
>   libs/flake/KoPathPoint.cpp a4bab35 
>   libs/flake/KoPathShape.cpp da6c928 
>   libs/flake/KoPointGroup.h 3770546 
>   libs/flake/KoPointGroup.cpp fe0dee1 
>   libs/flake/commands/KoPathPointMoveCommand.cpp 08f1e89 
> 
> Diff: http://git.reviewboard.kde.org/r/102389/diff
> 
> 
> Testing
> -------
> 
> Unit tests are still passing.
> 
> 
> Thanks,
> 
> Jan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110821/6f17724e/attachment.htm>


More information about the calligra-devel mailing list