Review Request: Fix crash in stage's slide sorter when one page is bigger than the viewport

Paul Mendez paulestebanms at gmail.com
Sat Aug 20 19:30:01 UTC 2011



> On Aug. 20, 2011, 7:27 p.m., Paul Mendez wrote:
> >

This line cause a crash when you click on the white space after the last slide and then switch to normal view, because the index returned by cursorSlideIndex is outside the pageList


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102351/#review5861
-----------------------------------------------------------


On Aug. 17, 2011, 7:25 p.m., Peter Simonsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102351/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 7:25 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> The slides sorter crashed on right click outside a page when the page itself is bigger than the viewport. Also fixed so that a page gets selected on right click if none is selected already as the code says it should be.
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrSlidesManagerView.cpp 1e3d08e 
> 
> Diff: http://git.reviewboard.kde.org/r/102351/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110820/0b5d1760/attachment.html>


More information about the calligra-devel mailing list