Review Request: more little things in libs

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102385/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

Use references por QRectF and QString.

One //FIXME because I can not see where the error variable gets a value.
One //TODO to avoid code duplication.
safeguards for possible null pointer dereferences.
Remove some unused variables.
Remove a double break;
Reduce the scope of variables.

Create a destructor to avoid a memory leak in FrameIterator.


Diffs
-----

  libs/flake/KoShapeFactoryBase.cpp fbbab41 
  libs/kopageapp/KoPACanvasBase.h 85b82e7 
  libs/kopageapp/KoPACanvasBase.cpp 4ee4bd3 
  libs/koproperty/editors/spinbox.cpp fbe49d5 
  libs/koreport/renderer/KoReportPreRenderer.cpp ce809c4 
  libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 7de1ed6 
  libs/kotext/opendocument/KoTextLoader.cpp ff1c793 
  libs/kotext/opendocument/KoTextWriter.cpp 01cb31f 
  libs/odf/KoXmlNS.h 41a1658 
  libs/odf/KoXmlNS.cpp 65a6316 
  libs/pigment/KoColorConversionSystem_p.h d87b05a 
  libs/pigment/KoColorConversions.cpp 5c3f708 
  libs/textlayout/FrameIterator.h 56138ae 
  libs/textlayout/FrameIterator.cpp e7dd615 
  libs/textlayout/KoTextShapeContainerModel.cpp 80ac07b 
  libs/widgets/KoUniColorChooser.cpp 68a9e60 

Diff: http://git.reviewboard.kde.org/r/102385/diff


Testing
-------

No differences in make tests


Thanks,

Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110820/54f5b6d0/attachment.htm>