Review Request: GSoC, Stage: Add a tabbar to switch between view modes

Thorsten Zachmann t.zachmann at zagge.de
Thu Aug 11 11:35:31 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102198/#review5630
-----------------------------------------------------------

Ship it!


Looks good please commit after changing the default to horizontal.


kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/102198/#comment5045>

    I think for the start and default we should use a horizontal tab bar. 


- Thorsten


On Aug. 10, 2011, 5:07 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102198/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 5:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add a tabbar to Stage on top of views, to switch between normal, notes and slides sorter view.
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrView.h 8c9d46158171b38363fdd9e716f4ab3d3b193200 
>   kpresenter/part/KPrView.cpp fb34504c8143c6cfd7cf5e6c11908897fa99cce9 
>   kpresenter/part/KPrViewModeNotes.cpp a7ed57f024b58c20a0fe79130f1090702a192697 
>   kpresenter/part/KPrViewModeSlidesSorter.h 8f0307ff8ccc922872cbcb589daea49d5b627270 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 9941f4bbde74d4cc3566eecdf314815876c482ab 
>   libs/kopageapp/KoPAView.h ee9b7950cebad23b2303bbce72e5164e4f42e1e5 
>   libs/kopageapp/KoPAView.cpp db61b647477194f062afd4f4f6ef9b6010b2f9a9 
>   libs/kopageapp/KoPAViewMode.h f47e07a2d1587e88f8d73d39ce902e4dc76c7942 
>   libs/kopageapp/KoPAViewMode.cpp cb9829a8287e1998e968ed196b98846ac2aef16f 
> 
> Diff: http://git.reviewboard.kde.org/r/102198/diff
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110811/2dac0d6c/attachment.htm>


More information about the calligra-devel mailing list