Review Request: Support for style:shadow in kotext styles

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102241/#review5515
-----------------------------------------------------------

Ship it!


Please fix the opening brackets to be on the same line as the if statements


libs/odf/KoShadowStyle.h
<http://git.reviewboard.kde.org/r/102241/#comment4945>

    Please move the implementation to the cpp file.


- Thorsten


On Aug. 7, 2011, 9:52 a.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102241/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 9:52 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add support for style:shadow in KoText/styles/KoTableStyle and KoTableCellStyle. This requires adding a shared KoShadow class that can be used to parse and store internally an opendocument compatible shadow.
> So far, no rendering is implemented, but at least this passes the loading/saving tests.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoTableCellStyle.h 491291a 
>   libs/kotext/styles/KoTableCellStyle.cpp 8fca08d 
>   libs/kotext/styles/KoTableStyle.h 61d0bf3 
>   libs/kotext/styles/KoTableStyle.cpp 8b152bf 
>   libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d36c0d2 
>   libs/odf/CMakeLists.txt 084bbf7 
>   libs/odf/KoShadowStyle.h PRE-CREATION 
>   libs/odf/KoShadowStyle.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102241/diff
> 
> 
> Testing
> -------
> 
> Loading/saving, OpenDocument compatibility unit test...
> 
> 
> Thanks,
> 
> Pierre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110808/5383e95c/attachment.htm>