Review Request: GSoC: Improve drag & drop of pages on KoDocumentSectionView on Thumbnails mode
Thorsten Zachmann
t.zachmann at zagge.de
Mon Aug 8 06:05:43 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102186/#review5488
-----------------------------------------------------------
Ship it!
Looks good. Please fix the commented part and commit
libs/main/KoDocumentSectionView.cpp
<http://git.reviewboard.kde.org/r/102186/#comment4923>
Please remove the qDebug statement of if you think it should be kept use kDebug
libs/main/KoDocumentSectionView.cpp
<http://git.reviewboard.kde.org/r/102186/#comment4924>
Please remove the qDebug statement of if you think it should be kept use kDebug
- Thorsten
On Aug. 2, 2011, 5:11 p.m., Paul Mendez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102186/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2011, 5:11 p.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> Draw a line in the place where the page or pages will be dropped.
> Fix a bug when dropping on the middle of two pages and no index were detected.
>
>
> Diffs
> -----
>
> libs/main/KoDocumentSectionView.h 0c2fd511a81d3b394175ff19962912b2df32cd7b
> libs/main/KoDocumentSectionView.cpp 0ff0ab3cdc2b735ea59aadd0b427ff5e177d9f64
>
> Diff: http://git.reviewboard.kde.org/r/102186/diff
>
>
> Testing
> -------
>
> Build and run
>
>
> Thanks,
>
> Paul
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110808/299d80c5/attachment.htm>
More information about the calligra-devel
mailing list